Skip to content

test: Google GenAI - test_live_run_with_parallel_tools should use tool_calls finish reason#3125

Merged
anakin87 merged 1 commit intomainfrom
fix-genai-stop-condition
Apr 9, 2026
Merged

test: Google GenAI - test_live_run_with_parallel_tools should use tool_calls finish reason#3125
anakin87 merged 1 commit intomainfrom
fix-genai-stop-condition

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Apr 9, 2026

Related Issues

Proposed Changes:

  • fix the test

How did you test it?

CI

Checklist

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Coverage report (google_genai)

This PR does not seem to contain any modification to coverable code.

@anakin87 anakin87 marked this pull request as ready for review April 9, 2026 09:05
@anakin87 anakin87 requested a review from a team as a code owner April 9, 2026 09:05
@anakin87 anakin87 requested review from davidsbatista and sjrl and removed request for a team and davidsbatista April 9, 2026 09:05
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right I should have run the tests! Thanks for the catch!

@anakin87 anakin87 merged commit cf6e76c into main Apr 9, 2026
13 checks passed
@anakin87 anakin87 deleted the fix-genai-stop-condition branch April 9, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants